FOF

Treadle Harness

Loom Assembly
Station 5: Quality Conformance Gate | Port 8788
RF
Active Run Docket specpack/0.4.1 • Gate 05: Quality Conformance

The spec library — every spec, readable by its owner

10 findings require resolution or ratification before Loom advances to deployment.
2 Blockers | 6 Defects | 2 Smells
T-2 — IMPROVE LibraryServer isolation & port defaults
agent: red-forman  •  today
BLOCKER
LibraryServer.start() mutated the shared _Handler class: two instances cross-wired — server A admitted events into server B's packs. Live-demonstrated by the reviewer.
fix: Per-instance binding via type('Bound', ...) exactly as InterviewServer does.
DEFECT
list_specs read file-layout keys off the normalized doc: every real pack showed the folder name as title and empty updated; the sort on updated was dead.
fix: Read title/updated; DERIVE the stage through derive_deliverable — never trust a stored copy (this also fixed three frozen packs displaying 'drafted', flagged by the worker before the verdict).
DEFECT
Fixed default port 8788 bound by tests: the suite failed whenever the standing library ran (5 failed/192 reproduced).
fix: LibraryServer defaults ephemeral; the CLI passes 8788.
DEFECT
A pack whose internal name differed from its folder was listed under a name that 404s.
fix: The folder is the route key; the internal name is display-only.
T-3 — IMPROVE Cross-tab routing and markdown jump links
agent: red-forman  •  today
BLOCKER FR-9
jump-links were dead for every cross-tab ID (card-T-x lives on another tab) and every ID inside rendered markdown (verified: marked emits plain text); the nomatch fallback referenced an element no code creates.
fix: jump() routes to the tab owning the ID family, lands after render via pendingJump; id!Html wraps IDs in parsed markdown text nodes only; misses toast honestly.
T-5 — IMPROVE Approval predicate and server error handling
agent: red-forman  •  today
DEFECT
The page checked S.spec.approved_at, a key /spec never emits — the Approve button reappeared after approval, proposing an act the record forbids.
fix: Read date.approved.{at,by} from the emitted layout.
DEFECT
do_POST had no catch-all: a read-only pack dir killed the socket with a traceback instead of JSON (reproduced).
fix: except Exception → 500 JSON, matching the room.
T-6 — IMPROVE Progress node position mapping
agent: red-forman  •  today
DEFECT
posOf mapped blocked to node 0: a stuck in-review pack rendered as 'Just started' — the opposite of honest states.
fix: posFor infers the furthest reached node from the record (done/doing work → in_progress; content → shaping); flags never move the path backward.
T-1 — IMPROVE Evidence overclaim & containment checks
agent: red-forman  •  today
DEFECT
Evidence overclaim (the T-1 / T-4 class, third instance): verify.expect claimed 'script tags neutralized' but no neutralization exists or is tested — the real posture is trusted-on-disk ( D-1). T-2's 'five real packs' was also wrong (seven), and T-6's recorded evidence ran only its focused file while verify named the full suite. T-7 with exits verified directly; this verdict is the durable disclosure.
fix: Expect texts reworded to the truth; the full gate ran directly on disk.
SMELL
/artifact followed symlinks out of the pack folder while the comment claimed containment.
fix: resolve() containment check — the comment's claim is now the code.
PACK — PASS Behavioral assertion coverage
agent: red-forman  •  today
SMELL
The structural tests blessed the dead branches (S-10): twenty string-presence asserts proved presence, not behavior — the institutionalized T-4 precedent.
fix: test_web_behavior.py now executes the page's real functions under node with a stubbed DOM: markdown ID wrapping, cross-tab routing, toast-on-miss, flag positioning, grouping, picked-reset — 19 behavior assertions.
Review Socket: Live | Total Findings: 10 (2 Blocker, 6 Defect, 2 Smell)
Markdown wrap: active • Treadle 8788/specpack